Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request adds a new method called 'embeddings' to the 'Engine' class in the 'openai/api_resources/engine.py' file. The 'embeddings' method takes 'params' as input and returns the embeddings from the OpenAI API. This change is made to implement the requested feature as described in issue openai#123. The 'embeddings' method uses the 'request' method provided by the 'Engine' class to make a POST request to the '/embeddings' endpoint with the provided 'params'. This change should not have any significant impacts on the existing functionality of the 'Engine' class, but it is recommended to review the implementation to ensure it aligns with the OpenAI API specifications. This change addresses the related issue by providing the requested 'embeddings' method functionality.
This PR fixes #1