This repository was archived by the owner on Aug 14, 2019. It is now read-only.
Exposing messageBubbleExtraVerticalSpace on flow layout#939
Closed
tonyxiao wants to merge 2 commits intojessesquires:developfrom
Closed
Exposing messageBubbleExtraVerticalSpace on flow layout#939tonyxiao wants to merge 2 commits intojessesquires:developfrom
tonyxiao wants to merge 2 commits intojessesquires:developfrom
Conversation
…d boundingRectWithSize being slightly off for different fonts issue
Owner
|
Hello everyone! I'm sorry to inform the community that I'm officially deprecating this project. 😢 Please read my blog post for details: http://www.jessesquires.com/blog/officially-deprecating-jsqmessagesviewcontroller/ Thus, I'm closing all issues and pull requests and making the necessary updates to formally deprecate the library. I'm sorry if this is unexpected or disappointing. Please know that this was an extremely difficult decision to make. I'd like to thank everyone here for contributing and making this project so great. It was a fun 4 years. 😊 Thanks for understanding, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to work around
boundingRectWithSizebeing slightly off for different fonts issue.This value is exposed because the right choice could depend on your choice of messageBubble font. If you find that your chat text is for example magically cut off or has too much space, adjust this value until you find the right visual fit. While it's not the right solution, the default magix number of
2.0fis only appropriate for the default font, each font seems to be calculated slightly off in its own way.