Skip to content

add authorization to header only if specified by user#2

Merged
josegonzalez merged 1 commit intojosegonzalez:masterfrom
johnyf:master
Sep 13, 2014
Merged

add authorization to header only if specified by user#2
josegonzalez merged 1 commit intojosegonzalez:masterfrom
johnyf:master

Conversation

@johnyf
Copy link
Copy Markdown
Contributor

@johnyf johnyf commented Sep 13, 2014

Otherwise 'basic ' + auth raises a TypeError because in get_auth the default value of auth is None. Since authentication credentials are optional arguments and the help message does not mention that at least one of them is required, this appears to be the intended behavior, taking into consideration also this warning message. Also, since it does work w/o credentials, it is nice to provide this option for any user that doesn't want to provide a password or token.

josegonzalez added a commit that referenced this pull request Sep 13, 2014
add authorization to header only if specified by user
@josegonzalez josegonzalez merged commit 5719a94 into josegonzalez:master Sep 13, 2014
whwright pushed a commit to whwright/python-github-backup that referenced this pull request Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants