#10568 - Animation does not work for inline elements#1318
Closed
sachinjain024 wants to merge 0 commit intojquery:masterfrom
sachinjain024:master
Closed
#10568 - Animation does not work for inline elements#1318sachinjain024 wants to merge 0 commit intojquery:masterfrom sachinjain024:master
sachinjain024 wants to merge 0 commit intojquery:masterfrom
sachinjain024:master
Conversation
Member
|
Is it just me or are there no changes here? |
Member
No, I (don't) see it too. The "Commits: ∞" is a nice touch, though. |
Member
|
Whoa. There was a commit here earlier. I suspect that @BlunderBoy force-pushed his own master back, there's a branch with the code but the PR wasn't made against it. @BlunderBoy I'll close this PR, but the new one needs a test case as well. Be sure that you've signed our CLA as well, per the information at http://contribute.jquery.org . Thanks! |
Author
|
@dmethvin I am so sorry. I thought PR was made against the new branch I had created So forced update my master branch to remove that particular commit. I have already signed CLA on contribute.jquery.org. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves the animation issue mentioned in http://bugs.jquery.com/ticket/10568
Issue: We make inline elements to inline-block before animations but in this case, since display was none, inline elements were not able to get convert to inline-block and hence animation was not working as shown in the jsfiddle in above issue.