Skip to content

fix: tween animations likely not working#1326

Closed
lampiclobe wants to merge 405 commits into1.9-stablefrom
master
Closed

fix: tween animations likely not working#1326
lampiclobe wants to merge 405 commits into1.9-stablefrom
master

Conversation

@lampiclobe
Copy link
Copy Markdown

On line 8693 there seems to be an error preventing tween animations from triggering. Before and after is below:

function createTweens( animation, props ) {
    jQuery.each( props, function( prop, value ) {
        var collection = ( tweeners[ prop ] || [] ).concat( tweeners[ "*" ] ), //here is the error line!
            index = 0,
            length = collection.length;
        for ( ; index < length; index++ ) {
            if ( collection[ index ].call( animation, prop, value ) ) {

                // we're done with this property
                return;
            }
        }
    });
}
function createTweens( animation, props ) {
    jQuery.each( props, function( prop, value ) {
        var collection = (tweeners[ "*" ]).concat( tweeners[ prop ] ), //and this is the fix!
            index = 0,
            length = collection.length;
        for ( ; index < length; index++ ) {
            if ( collection[ index ].call( animation, prop, value ) ) {

                // we're done with this property
                return;
            }
        }
    });
}

When this code is appended a new error brings out here:

if ( this.options.duration) {
    this.pos = eased = jQuery.easing[ this.easing ](  //here thrown an error!!
        percent, this.options.duration * percent, 0, 1, this.options.duration
    );
} 

And fix:

if ( this.options.duration && jQuery.easing[ this.easing ]) {
    this.pos = eased = jQuery.easing[ this.easing ](
        percent, this.options.duration * percent, 0, 1, this.options.duration
    );
}

If somewhere in the wild suffers from non-animating Tweens, let him be informed.
Cheers!

gibson042 and others added 30 commits January 17, 2013 17:01
… dismissed the XML as parsed by the XHR instance.
Stylish yet functional, this set of grunt plugins should provide hours of trouble-free operation until rc6 comes out.
…iteral "undefined" for safer uglification

(cherry picked from commit ec9b38a)
Turns out this is still needed by Safari 5.1, which we're still supporting.

This reverts commit c4b1da4.
terrycojones and others added 27 commits June 19, 2013 19:17
Normally we'd avoid doing this on a patch release, but Chrome Canary is
spewing deprecation warnings already and that's generating bug tickets.
Per the discussion here:
https://code.google.com/p/chromium/issues/detail?id=256636

Thanks to the Chrome team for the quick response!

This reverts commit d53ddc9.
@markelog
Copy link
Copy Markdown
Member

markelog commented Aug 7, 2013

Thanks for taking the time to contribute to the jQuery project. But this pull request is incorrect, if you want to help please read this

@markelog markelog closed this Aug 7, 2013
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.