Closed
Conversation
Member
|
I have some concerns regarding the performance of that nested for-loop. Also, I think this could be achieved in less code. |
Member
|
But overall - neat idea! |
Member
|
Strike my "less code" statement - nice work. |
Author
|
I don't know how to avoid a nested loop in removeClass function. I'm open to suggestions. |
Contributor
|
As http://bugs.jquery.com/ticket/8088 was closed as wontfix I close this pull request too. Thanks for the effort. Please report back on the ticket with a link, if you decide to release this as a plugin, because this sure is a cool feature. So we can people point at it if needs for something like that comes up. |
Author
|
I created jquery-regexp-classes repo that has jquery.hasClass.js and jquery.removeClass.js plugins. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://forum.jquery.com/topic/removeclass-regexp-and-hasclass-regexp