Skip to content

Import specs from rubysl-zlib#1611

Closed
LTe wants to merge 1 commit intojruby:masterfrom
LTe:zlib-specs
Closed

Import specs from rubysl-zlib#1611
LTe wants to merge 1 commit intojruby:masterfrom
LTe:zlib-specs

Conversation

@LTe
Copy link
Copy Markdown

@LTe LTe commented Apr 5, 2014

New zlib from ruby allows streams to be processed without huge
memory growth. There is specs for new API of #inflate and #deflate
methods. Each of these methods may take a block which can process
one chunk of the stream.

Related to #1216

@headius
Copy link
Copy Markdown
Member

headius commented Apr 7, 2014

I'm fine updating rubyspec with rubysl stuff that's actively maintained, but we'd need to get tags for any new failures too before merging. Perhaps you can give that a shot?

New zlib from ruby allows streams to be processed without huge
memory growth. There is specs for new API of #inflate and #deflate
methods.  Each of these methods may take a block which can process
one chunk of the stream.
@enebo
Copy link
Copy Markdown
Member

enebo commented Jul 16, 2014

My second comment is how do we update these periodically? I am not against doing this but we should think about documenting or automating pull various suites in.

@headius
Copy link
Copy Markdown
Member

headius commented Nov 2, 2014

I'm fine pulling these in at this point. You added them to rubysl-zlib too, so thank you for that.

It's unfortunate we now have to check several dozen repositories to get the specs for these libraries.

@headius
Copy link
Copy Markdown
Member

headius commented Nov 2, 2014

PR no longer merges. We will update and merge it when we can. If you can get to it, that would help us a lot.

@chrisseaton
Copy link
Copy Markdown
Contributor

@eregon am I right in thinking the library specs from rubysl-zlib should now be merged from your work on RubySpec? If so this can be closed.

@eregon
Copy link
Copy Markdown
Member

eregon commented Jan 3, 2016

@chrisseaton Yes, except new specs added there.
I imported the new specs from rubysl-zlib in ruby/rubyspec.
They will be in jruby on the next spec merge.

@eregon eregon closed this Jan 3, 2016
@enebo enebo modified the milestone: Non-Release May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants