re-implement the option to lazy bind Java:: constants#8368
Merged
kares merged 6 commits intojruby:masterfrom Oct 18, 2024
Merged
re-implement the option to lazy bind Java:: constants#8368kares merged 6 commits intojruby:masterfrom
kares merged 6 commits intojruby:masterfrom
Conversation
This reverts commit 31f1ed6.
Member
|
@kares Are you happy with this one? Definitely a good idea to get this fixed in 9.4.9.0. |
Member
Author
|
seems to work fine. the pre 9.4.7.0 |
headius
approved these changes
Oct 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a second attempt at resolving (#8349) the slight regression introduced at 31f1ed6
the commit is reverted and the
-Xji.eager.constantsfeature is re-implemented more conservatively (without effecting allgetProxyClasscallers).also rename and cleaned up the method setting the actual proxy class constant, the tests are a bit futile but should prevent doing a similar
getProxyClassrefactoring, which would have undesired side effects.