Permute indy invoke paths to reduce uncached stack#8446
Open
headius wants to merge 1 commit intojruby:masterfrom
Open
Permute indy invoke paths to reduce uncached stack#8446headius wants to merge 1 commit intojruby:masterfrom
headius wants to merge 1 commit intojruby:masterfrom
Conversation
Passing all uncached calls through the varargs form simplifies maintenance, but requires an indirect dispatch for the first invocation. This adds several frames to the stack for such uncached calls. The patch here permutes the InvokeSite.invoke methods so they can directly dispatch to the to-be-cached handle, reducing the number of stack frames in a backtrace. This is unlikely to reduce actual stack consumption due to the unoptimized MethodHandle and LambdaForm between the invokeExact call and the target method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing all uncached calls through the varargs form simplifies maintenance, but requires an indirect dispatch for the first invocation. This adds several frames to the stack for such uncached calls. The patch here permutes the InvokeSite.invoke methods so they can directly dispatch to the to-be-cached handle, reducing the number of stack frames in a backtrace.
This is unlikely to reduce actual stack consumption due to the unoptimized MethodHandle and LambdaForm between the invokeExact call and the target method.
See #8410 for original PR closed by 9.4-dev branch deletion.