private_constant should just update existing autoload#8995
Merged
headius merged 1 commit intojruby:masterfrom Sep 5, 2025
Merged
private_constant should just update existing autoload#8995headius merged 1 commit intojruby:masterfrom
headius merged 1 commit intojruby:masterfrom
Conversation
The logic here was proceeding to set the existing autoload to UNDEF, which then triggered it to be removed as a failed autoload. This left us with a constant table containing a private entry of UNDEF but no autoload in the table to load for it. The modified logic checks if the incoming value was also UNDEF, indicating that the value was a previously-unloaded or in-progress autoload, and leaves the autoload table alone while just updating the constant table with the new visibility. Fixes jruby#8923
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic here was proceeding to set the existing autoload to UNDEF, which then triggered it to be removed as a failed autoload. This left us with a constant table containing a private entry of UNDEF but no autoload in the table to load for it.
The modified logic checks if the incoming value was also UNDEF, indicating that the value was a previously-unloaded or in-progress autoload, and leaves the autoload table alone while just updating the constant table with the new visibility.
Fixes #8923