Fix CoverageData.mergeLines when coverage increases#9098
Merged
headius merged 1 commit intojruby:masterfrom Dec 2, 2025
Merged
Fix CoverageData.mergeLines when coverage increases#9098headius merged 1 commit intojruby:masterfrom
headius merged 1 commit intojruby:masterfrom
Conversation
Contributor
Author
|
|
d55de8a to
f5d1783
Compare
f5d1783 to
f523ed1
Compare
Member
|
Great, thank you! I've approved CI to run and I'll review. If you haven't already, please submit a PR to update https://github.com/jruby/jruby/blob/master/USERS.md with your use case. It really helps us show others what JRuby is capable of! |
Contributor
Author
I'm really not much of a user, regrettably. I've taken to running CI of personal projects with easily available Ruby implementations (via ruby/setup-ruby), which helps surface incompatibilities. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been having intermittent problems running RSpec tests on JRuby, with an
ArrayIndexOutOfBoundsExceptionhappening all of a sudden.Stacktrace shows that coverage is the problem:
It also looks like enabling coverage for
evaled code may be the problem, as not enabling it solved it at least in most recent case. However, in a different project it makes no difference, so not sure. Also, in this case I was only usingclass_evalwith a block, not a string 🤷Anyway, I looked in the code and found the problem. In
mergeLinesthere is logic for increasing the size of the list, but the main merging loop was getting values from the original list instead, going out of bounds.This PR solves the problem. I ran this against my RSpec suite, and there is no longer an error.