Extract float formatting into a static method to use with to_json#9200
Merged
headius merged 1 commit intojruby:masterfrom Jan 30, 2026
Merged
Extract float formatting into a static method to use with to_json#9200headius merged 1 commit intojruby:masterfrom
headius merged 1 commit intojruby:masterfrom
Conversation
Member
|
@evaniainbrooks This is great, thank you! The spec should probably go in spec/ruby if that behavior is not already in specs, and we'll probably want to backport this to 9.4 so the json gem doesn't break for future versions, but this could probably go into 10.0.3.0 to get the json work moving forward. Requesting review from @enebo. |
…n converting Float to JSON
28d802e to
6b095be
Compare
Contributor
Author
|
I reverted the added spec because this is certainly already covered in |
headius
approved these changes
Jan 30, 2026
Member
headius
left a comment
There was a problem hiding this comment.
Looks good. I will backport to 9.4 since we will need the json gem to keep working there once it starts using this API.
Member
|
@evaniainbrooks Thank you! Let me know if I can do anything else to help. |
This was referenced Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9199
ruby/json#817