Fix encoding fallback error handling and error message formatting#9205
Merged
headius merged 1 commit intojruby:masterfrom Feb 2, 2026
Merged
Fix encoding fallback error handling and error message formatting#9205headius merged 1 commit intojruby:masterfrom
headius merged 1 commit intojruby:masterfrom
Conversation
- Raise ArgumentError("too big fallback string") when a fallback
function returns a value that cannot be encoded to the destination
encoding. Previously, the invalid character was silently dropped.
- Format UTF-8 codepoints as U+XXXX in UndefinedConversionError messages
instead of showing the raw byte dump (e.g., "U+FFFD" instead of
"\xEF\xBF\xBD"), matching MRI behavior.
These changes fix all 12 failing specs in encode_spec.rb related to
fallback option error handling.
Member
|
Nice! I'll review. |
headius
approved these changes
Feb 2, 2026
Member
headius
left a comment
There was a problem hiding this comment.
Love seeing those tags disappear!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #9182 as suggested by @headius.
This PR fixes the remaining 12 failing specs in
spec/ruby/core/string/encode_spec.rb:Raise
ArgumentError("too big fallback string")when a fallback function returns a value that cannot be encoded to the destination encoding. Previously, the invalid character was silently dropped.Format UTF-8 codepoints as
U+XXXXinUndefinedConversionErrormessages instead of showing the raw byte dump (e.g.,U+FFFDinstead of"\xEF\xBF\xBD"), matching MRI behavior.Test plan
encode_spec.rbnow pass (previously 12 were tagged as failing)spec/tags/ruby/core/string/encode_tags.txtsince all specs now pass