Skip to content

Fix block argument destructuring with optional parameters#9211

Merged
headius merged 2 commits intojruby:masterfrom
evaniainbrooks:9208-block-param-default
Feb 10, 2026
Merged

Fix block argument destructuring with optional parameters#9211
headius merged 2 commits intojruby:masterfrom
evaniainbrooks:9208-block-param-default

Conversation

@evaniainbrooks
Copy link
Contributor

@evaniainbrooks evaniainbrooks commented Feb 3, 2026

issue #9208

@evaniainbrooks evaniainbrooks force-pushed the 9208-block-param-default branch 2 times, most recently from 2bd046d to fd6b541 Compare February 3, 2026 12:39
@headius
Copy link
Member

headius commented Feb 4, 2026

Thanks for looking into this. That's a peculiar issue.

@evaniainbrooks evaniainbrooks force-pushed the 9208-block-param-default branch from 2b12e64 to 28dd1ae Compare February 5, 2026 02:06
@headius
Copy link
Member

headius commented Feb 5, 2026

The sequel and concurrent-ruby job fails were due to a bug in #9198 that caused the build to generate broken binstubs. Fixed in f21870a.

@evaniainbrooks evaniainbrooks force-pushed the 9208-block-param-default branch from 28dd1ae to 2f436b1 Compare February 7, 2026 03:06
@evaniainbrooks evaniainbrooks marked this pull request as ready for review February 7, 2026 03:44
@evaniainbrooks
Copy link
Contributor Author

@headius thanks. I think everything is green now. The single failing test looks like an unrelated time-sensitive issue.

@evaniainbrooks evaniainbrooks force-pushed the 9208-block-param-default branch from f0ac831 to 574c519 Compare February 8, 2026 18:22
@headius
Copy link
Member

headius commented Feb 10, 2026

@evaniainbrooks I think those last failures are due to a similar change being needed in some JIT-related path. That spec run runs the language specs 4 times in the same runtime, so that the JIT can fire and fully bind all calls.

I'll see if I can suss out what's wrong.

@headius
Copy link
Member

headius commented Feb 10, 2026

I think I found the right spot in JIT's argument-handling logic to patch. It has diverged for various reasons and needs to be reined in, but if this passes we can proceed for now.

@headius headius merged commit 05ae525 into jruby:master Feb 10, 2026
79 checks passed
@evaniainbrooks
Copy link
Contributor Author

@headius thank you for the explanation. That certainly explains some other things that perplexed me while I was stepping through this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants