Ignore empty kwrest in Data subtypes' constructors#9215
Merged
headius merged 1 commit intojruby:masterfrom Feb 10, 2026
Merged
Conversation
When passing empty kwrest into a method, `hasKeyword` will be true but there will not actually be any keyword hash in the argument list. We need to also check for "empty" keywords before proceeding to use any incoming kwargs hash. Fixes jruby#9214
3da9634 to
7cccb7e
Compare
headius
added a commit
to headius/jruby
that referenced
this pull request
Feb 10, 2026
This expands the fix from jruby#9215 to Struct and creats a new utility method for checking that keywords were passed AND were non-empty. Fixes jruby#9224.
rossroberts-toast
added a commit
to rossroberts-toast/elasticgraph
that referenced
this pull request
Mar 24, 2026
Upgrades JRuby CI builds from 10.0 to 10.0.4.0 and setup-ruby from v1.288.0 to v1.295.0 across all workflow files. JRuby patches updated for 10.0.4.0 compatibility: - Remove the `< 10.0.4.0` version gate so patches remain active. - Remove Bug 1 (Data.new splat forwarding) — fixed upstream in 10.0.4.0 (jruby/jruby#9215, jruby/jruby#9225). - Keep Bug 2 (Data#to_h/deconstruct on subclasses) — still needed, now applied via a Data.define hook since JRuby 10.0.4.0 defines to_h directly on each Data.define subclass. - Work around a new JRuby 10.0.4.0 bug where `include`-ing a module in a Data.define block causes subclass instances to have nil fields in certain call patterns. Fix by defining instance methods directly in the Data.define block instead of using `include InstanceMethods`.
myronmarston
pushed a commit
to block/elasticgraph
that referenced
this pull request
Mar 25, 2026
* Upgrade to JRuby 10.0.4.0 and setup-ruby v1.295.0 Upgrades JRuby CI builds from 10.0 to 10.0.4.0 and setup-ruby from v1.288.0 to v1.295.0 across all workflow files. JRuby patches updated for 10.0.4.0 compatibility: - Remove the `< 10.0.4.0` version gate so patches remain active. - Remove Bug 1 (Data.new splat forwarding) — fixed upstream in 10.0.4.0 (jruby/jruby#9215, jruby/jruby#9225). - Keep Bug 2 (Data#to_h/deconstruct on subclasses) — still needed, now applied via a Data.define hook since JRuby 10.0.4.0 defines to_h directly on each Data.define subclass. - Work around a new JRuby 10.0.4.0 bug where `include`-ing a module in a Data.define block causes subclass instances to have nil fields in certain call patterns. Fix by defining instance methods directly in the Data.define block instead of using `include InstanceMethods`. * remove specific version pin * add jruby issue number * remove unneeded jruby_patches file and unused module InstanceMethods * remove require deleted jruby patch file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When passing empty kwrest into a method,
hasKeywordwill be true but there will not actually be any keyword hash in the argument list. We need to also check for "empty" keywords before proceeding to use any incoming kwargs hash.Fixes #9214