Internalize and threadsafetify String#unicode_normalize#9232
Merged
headius merged 1 commit intojruby:masterfrom Feb 11, 2026
Merged
Internalize and threadsafetify String#unicode_normalize#9232headius merged 1 commit intojruby:masterfrom
headius merged 1 commit intojruby:masterfrom
Conversation
In CRuby, this code was moved into C in 2017 and the .rb file was removed shortly after (released in Ruby 2.5.0). This patch does the following: * Move the script into the JRuby jar so it can be loaded as part of our boot logic. * Fix the race to load UnicodeNormalize by removing the constant definition check and restoring the method redefinition (see jruby#9231). Fixes jruby#9231 and relates to jruby#6362.
Member
Author
|
CRuby changes to move this into C code: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In CRuby, this code was moved into C in 2017 and the .rb file was removed shortly after (released in Ruby 2.5.0).
This patch does the following:
Fixes #9231 and relates to #6362.