Fixed incorrect inventory listing in inventory.txt#3
Merged
Conversation
There was a problem hiding this comment.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ✅ | |
| Part 1 - Q2 | ✅ | |
| Part 1 - Q3 | ✅ | |
| Part 1 - Q4 | ✅ | |
| Part 1 - Q5 | ✅ | |
| Part 1 - Q6 | ✅ | |
| Part 1 - Q7 | ❌ | One or more files with ipaddr in data/raw not removed.; One or more files with ipaddr in data/processed/user_logs not removed |
| Part 1 - Q8 | ❌ | data/inventory.txt does not exist |
| Part 2 | ✅ |
Please address the issues listed above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Corrected the script for pulling inventory list to show all logs in the sub folders
What did you learn from the changes you have made?
How to list all contents in subfolders
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
None
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I was not being precise with the syntax and failed to check the test results thoroughly. I went back to take the time to look at everything line by line.
How were these changes tested?
Ran the script on Git Bash. Checked all of the results step by step with a checklist
A reference to a related issue in your repository (if applicable)
Checklist