Combine models with retain_original=False, and docs#78
Merged
jsvine merged 2 commits intojsvine:masterfrom Sep 27, 2017
Merged
Conversation
Also, document how to create models file-by-file and combine them into one model.
Owner
|
Thank you, Tyler! Great catch and great fix. Much appreciated. |
Owner
|
Merged, and now available in (And nice tip about spaCy.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for making this library, it's really great and easy to use. I was trying to load a large corpus file-by-file and noticed an error when trying to use
markovify.combineon models withretain_original=False:I think this change fixes the issue.
And, I documented how to create models file-by-file and combine them into one model in the README. I was wondering how to do that when I first started using markovify.
Also, kind of unrelated, but I added a tip about using spaCy to the README too.