Open
Conversation
Dmytro-Bonislavskyi
suggested changes
Apr 2, 2026
Dmytro-Bonislavskyi
left a comment
There was a problem hiding this comment.
Hi @jwpearson94
Everything fine in general, especially I like that you SELECT named columns instead of using '*'. Just a couple of small modifications needed:
In
Q2 you must sort by (ORDER BY) both last name and first name.
Q7 is missing the requested ORDER BY.
Q9 You wrote >= 2000, but if we want to be precise the task was> 2000.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
< UofT-DSI | SQL - Assignment 1 -->
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
updating assignment1.sql file with queries
added a pdf containing a logical structure diagram
filled in section 4 of assignment.md file
What did you learn from the changes you have made?
how to write syntax in SQL lite
Checklist
assignment-one.