Skip to content

Upgrade jffi to version 1.3.14 with JDK23+ support#409

Merged
Stewori merged 1 commit intojython:masterfrom
wfouche:dev/jffi-1.3.14
Mar 2, 2026
Merged

Upgrade jffi to version 1.3.14 with JDK23+ support#409
Stewori merged 1 commit intojython:masterfrom
wfouche:dev/jffi-1.3.14

Conversation

@wfouche
Copy link
Copy Markdown
Member

@wfouche wfouche commented Dec 20, 2025 •
edited
Loading

Resolves the following warning with Jython is used with JDK23 or later.

WARNING: A terminally deprecated method in sun.misc.Unsafe has been called
WARNING: sun.misc.Unsafe::putLong has been called by com.kenai.jffi.UnsafeMemoryIO$UnsafeMemoryIO64 (file:/home/wfouche/.m2/repository/com/github/jnr/jffi/1.3.13/jffi-1.3.13.jar)
WARNING: Please consider reporting this to the maintainers of class com.kenai.jffi.UnsafeMemoryIO$UnsafeMemoryIO64
WARNING: sun.misc.Unsafe::putLong will be removed in a future release

To be considered for inclusion in Jython 2.7.5

@wfouche
Copy link
Copy Markdown
Member Author

wfouche commented Dec 20, 2025

@jeff5 , please review this PR.

@wfouche wfouche mentioned this pull request Jan 14, 2026
Open
@Stewori
Copy link
Copy Markdown
Member

Stewori commented Feb 19, 2026

Note to reviewers:
Whenever a binary file is modified I routinely doublecheck that the file is actually the file it is supposed to be. As expected, I can confirm (via cmp) that in this PR the provided jffi-1.3.14.jar is binary identical to the one distributed at https://repo1.maven.org/maven2/com/github/jnr/jffi/1.3.14

@Stewori
Copy link
Copy Markdown
Member

Stewori commented Feb 19, 2026

@jeff5 since you seem busy ATM and this PR has stalled for a couple of weeks I'll take the initiative to merge it. Changes look good, tests pass, I confirmed identity of the binary. In any case I see no way of releasing Jython 2.7.5 without this update. So, merging seems like a no-brainer to me. I'll wait for another couple of days to allow potential other reviews. If nothing comes up, I'll press the merge button on next Wednesday/Feb 25th.
@wfouche Thank you for working on this!

@Stewori Stewori merged commit d169bf0 into jython:master Mar 2, 2026
8 checks passed
iotonio added a commit to BisonSchweizAG/jython that referenced this pull request Mar 11, 2026
@iotonio @ohumbel
@wfouche @Stewori
Merge upstream master (#75)
4405677 
* Perform the jakarta EE migration (jython#414)

* Replace javax.servlet with jakarta.servlet
* Move the jakarta.servlet related classes to a new package org.python.servlet
* Move modjy's PyFilterTest and PyServletTest to their new package, too
* Update NEWS

* Upgrade jffi to version 1.3.14 with JDK23+ support (jython#409)

* Update NEWS

* highlight jffi update to resolve dependence on sun.misc.Unsafe
* bugs fixed: added older issue regarding javax.servlet to jakarta.servlet namespace change

---------

Co-authored-by: Otmar Humbel <[email protected]>
Co-authored-by: Werner Fouché <[email protected]>
Co-authored-by: Stefan Richthofer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wfouche @Stewori