Skip to content

FIX: Send all > 64k not working#80

Closed
gbach wants to merge 1 commit intojython:masterfrom
gbach:master
Closed

FIX: Send all > 64k not working#80
gbach wants to merge 1 commit intojython:masterfrom
gbach:master

Conversation

@gbach
Copy link
Copy Markdown

@gbach gbach commented Jan 22, 2021

See #60

@jeff5
Copy link
Copy Markdown
Member

jeff5 commented Jun 13, 2022

Removed from milestone 2.7.3 because #185 is expected to resolve (within a somewhat broader in scope).

@jeff5
Copy link
Copy Markdown
Member

jeff5 commented Jun 15, 2022

@gbach : I've merged similar code as part of #185, so we can close this. Thanks however for your interest in solving it and keeping this on the to-do list, which has led to tidying up several loose ends in this bit of _socket.py.

The use of a memoryview is good, and it seemed to improve performance, used consistently, in send() too.

You have to remember to dispose of them because they lock the underlying object. Even a slice of a memoryview is a memoryview, which I forgot in my first change set. with is a good idiom for this.

@jeff5 jeff5 closed this Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants