Skip to content

upload assignment_1#1

Open
karennh21 wants to merge 1 commit intomainfrom
assignment-1
Open

upload assignment_1#1
karennh21 wants to merge 1 commit intomainfrom
assignment-1

Conversation

@karennh21
Copy link
Copy Markdown
Owner

No description provided.

Copy link
Copy Markdown

@xindizhang xindizhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Well-written and well-documented code. Assignment 1 is complete – no changes needed.

Minor suggestions for future improvement:

  1. In places like:
  if sorted(word_a.lower()) == sorted(word_b.lower()):
    return True 
  else:
    return False

You can simplify this by directly returning the boolean expression by using:
return sorted(word_a.lower()) == sorted(word_b.lower())
This makes the code cleaner

  1. Quick reminder for future submissions — including a brief PR description is good practice, as it helps your "project-mate" quickly understand what’s going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants