Open
Conversation
efantinatti
suggested changes
Dec 11, 2025
There was a problem hiding this comment.
Hi @kerensa-wong Q1 is OK. Q2 you may consider running max and mean. Q3 you may also consider testing all the files and see which of them you get the True values.
Also your submission branch is assignment-two instead of assignment-2.
Best,
E. Fantinatti
efantinatti
suggested changes
Dec 14, 2025
efantinatti
left a comment
There was a problem hiding this comment.
Hi @kerensa-wong Q3 looks good but Q2 is also not showing contents, just lenghts. Consider printing the Max, min and mean outputs.
Best
@efantinatti
Owner
Author
|
Implemented a for-loop for Q2 to check both output length and contents, including max, min and mean output, against each reference CSV file. |
efantinatti
approved these changes
Dec 14, 2025
efantinatti
left a comment
There was a problem hiding this comment.
Thanks @kerensa-wong Q2 is great now. You are good to merge into main.
Best,
@efantinatti
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I updated the codes to assignment_2.ipynb
What did you learn from the changes you have made?
I learnt defining functions to get summary statistics for patient data, checking anomalies from there
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
The code I wrote should be more straight-foward and easy reading.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist