Skip to content

fix: align pull with image create and improve reclaim size input#44

Merged
sjmiller609 merged 4 commits intomainfrom
codex/pull-alias-image-create
Mar 23, 2026
Merged

fix: align pull with image create and improve reclaim size input#44
sjmiller609 merged 4 commits intomainfrom
codex/pull-alias-image-create

Conversation

@sjmiller609
Copy link
Contributor

@sjmiller609 sjmiller609 commented Mar 23, 2026

Summary

  • make hypeman pull use the same image-create request path and --tag handling as hypeman image create
  • preserve the legacy human-readable pull auto output, while keeping explicit --format output supported
  • accept human-readable values for resources reclaim-memory --reclaim-bytes while treating bare numbers as raw bytes
  • add tests for shared image-create parsing and reclaim-size parsing
  • update the README and command help/examples to reflect the new behavior

Testing

  • go test ./...
  • go run ./cmd/hypeman pull --help
  • go run ./cmd/hypeman image create --help
  • go run ./cmd/hypeman resources reclaim-memory --help

Note

Medium Risk
Medium risk: changes CLI request/formatting behavior for pull/image create and alters parsing of resources reclaim-memory --reclaim-bytes, which could impact scripts relying on previous outputs or strict numeric inputs.

Overview
Unifies image creation logic by factoring shared tag parsing/param building into buildImageNewParams and reusing it from both image create and pull, including consistent malformed-tag warnings.

Updates hypeman pull to behave as an alias of image create: it now supports --tag and, when --format is set, returns structured output via ShowJSON while preserving the legacy human-readable output when --format auto.

Improves resources reclaim-memory --reclaim-bytes to accept human-readable sizes (e.g., 512MB, 2 GB) via datasize, with validation for empty/zero/overflow inputs, and adds focused unit tests for the new parsing and shared image param builder.

Written by Cursor Bugbot for commit cc4c37b. This will update automatically on new commits. Configure here.

@sjmiller609 sjmiller609 changed the title Unify pull with image create Align pull with image create and improve reclaim size input Mar 23, 2026
@sjmiller609 sjmiller609 marked this pull request as ready for review March 23, 2026 19:51
@sjmiller609 sjmiller609 changed the title Align pull with image create and improve reclaim size input fix: align pull with image create and improve reclaim size input Mar 23, 2026
@sjmiller609 sjmiller609 merged commit 27fc6d2 into main Mar 23, 2026
4 checks passed
@sjmiller609 sjmiller609 deleted the codex/pull-alias-image-create branch March 23, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant