Tags: kestrel-code/rules_python
Tags
fix(pipstar): correctly handle complex self deps (bazel-contrib#3527) It seems that with the `pipstar` port there was a typo and the initial tests that we had for Python were insufficient to catch such a regression. The second if statement where we loop through packages again had a `req` instead of `req_` in the `if` statement and the test coverage was not sufficient. I have abstracted the if statement into a function to easier spot such issues and added an extra test to ensure that a regression would be actually caught. With this the Starlark test suite is now officially more robust than the Python version. Fixes bazel-contrib#3524 --------- Co-authored-by: Richard Levasseur <[email protected]> (cherry picked from commit c52aeaa)
fix(pipstar): Handle dep appearing in extra both conditionally and un… …conditionally (bazel-contrib#3513) Fixes bazel-contrib#3511 (cherry picked from commit 5fe50fb)
fix(pipstar): Handle dep appearing in extra both conditionally and un… …conditionally (bazel-contrib#3513) Fixes bazel-contrib#3511 (cherry picked from commit 5fe50fb)
fix (venv_site_packages): Fix wrong runfiles.symlinks when py_binary … …is not in root module (bazel-contrib#3505) When: 1) venv_site_packages is on 2) we have a py_binary in a non-root module (e.g. a tool used in rules), and it uses python deps that result in usage of runfiles.symlinks, the `ctx.runfile` based symlinks end up going in the wrong folder (`_main`), while the `ctx.actions.symlink(...)` files go in the right place. This results in an invalid `venv` and import errors. The reason is that `actions.symlinks` always go to the `_main` module, as [Bazel docs explain](https://bazel.build/extending/rules#runfiles_symlinks). To send symlinks to other modules, one needs to use root_symlinks and prefix them with the right module name. Fixes: bazel-contrib#3503 --------- Co-authored-by: Shayan Hoshyari <[email protected]> Co-authored-by: Richard Levasseur <[email protected]> (cherry picked from commit f9992f7)
doc: Add a snippet on how people can use 3.8 now onwards (bazel-contr… …ib#3502) Thanks to Ted Kaplan (@thirtyseven) for the snippet. (cherry picked from commit ffb7001)
fix(venv): Fix all .so files missing when py_binary lives at //:BUILD (… …bazel-contrib#3474) When `.label.package` was "" (empty string), doing `"{}/{}".format(ctx.label.package, bin_venv_path)` created an absolute path, which caused files to be ignored later, as they no longer looked to be part of the correct prefix. An empty package name occurs when the target is in `//:BUILD` with venv on. To fix, use skylib's `paths` instead, which handles it correctly and won't add the `/` prefix. Fixes bazel-contrib#3470 Co-authored-by: Shayan Hoshyari <[email protected]>
chore: update version markers for 1.8 release (bazel-contrib#3472) Update version markers for the 1.8 release. Work towards bazel-contrib#3466
fix: make CI pass with the next version of Bazel (9.0.0rc1) (bazel-co… …ntrib#3393) Explicitly load CcToolchainConfigInfo in the fake cc toolchain config. For examples/bzlmod, bump rules_rust to a newer version so that it pulls in dependencies that work correctly with Bazel 9.0.0rc1. Work towards bazel-contrib#3392 (cherry picked from commit 49b6630)
PreviousNext