Skip to content

Assignment-1#1

Open
kgogina wants to merge 3 commits intomainfrom
assignment-1
Open

Assignment-1#1
kgogina wants to merge 3 commits intomainfrom
assignment-1

Conversation

@kgogina
Copy link
Copy Markdown
Owner

@kgogina kgogina commented May 3, 2024

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Create a 1 function that compares 2 strings for Anagram (not case sensitive). And second function if it is an Anagram with the additional condition is_case_sensitive.

What did you learn from the changes you have made?

How to use inbuild functions and if...else conditions.

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Python syntax.

How were these changes tested?

With the proposed test cases from the task.

A reference to a related issue in your repository (if applicable)

@mentions of the person or team responsible for reviewing proposed changes (At least 2 people)

I did 2 commits. In the first commit, in the function, anagram_checker_case_sensitive was a mistake with the Return => statement was inside of else. I fixed it in the second, test and made a second commit.

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part B of your code executes with Error. As a hint, this is likely an indentation error. Please revise and resubmit

Copy link
Copy Markdown

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Suggestion would be to better comment your code for improved clarity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants