Open
Conversation
pedram-aliniaye-asli
approved these changes
Sep 15, 2024
pedram-aliniaye-asli
left a comment
There was a problem hiding this comment.
You did a great job here!
Just a few quick notes:
- In
patient_summaryfunction, you don't need to return the result in each if statement, you can just simply return the result once at the end. - In
detect_problemsfunction, there is no need to call thecheck_zeros(x)function once and then do it again to return the result. You can just call it once and return the result either directly or from a variable that has the result stored in it.
Please go ahead and close this pull request now. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I am adding new code to calculate summary statistics (mean, max, min) of inflammation levels for one of 60 patients during 40 session. I will also write code to check for missing or incorrect data (e.g., negative values) and handle these appropriately.
What did you learn from the changes you have made?
I learned that using Numpy made the things easier in coding. Without Numpy, one needs to parse the data into a list, then iterate over each patient for the 40 sessions to float each value, then calculate the summary statistics... etc.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist