Open
Conversation
juliagallucci
suggested changes
May 7, 2024
juliagallucci
left a comment
There was a problem hiding this comment.
Part B executes with error. your function should consider case sensitivity; for example
anagram_checker("Slient", "liSten", True) should return True!
Please revise
khollah1
commented
May 12, 2024
Owner
Author
khollah1
left a comment
There was a problem hiding this comment.
I have updated my assignment-1 part 2 code for your review. Thank you.
juliagallucci
suggested changes
May 13, 2024
juliagallucci
left a comment
There was a problem hiding this comment.
Part B executes with error, hint- you need to take into consideration case sensitivity when the third argument is true. eg if we care about case sensitivity, Silent and Listen would return false, but Silent and liSten would return true . please revise
juliagallucci
approved these changes
May 17, 2024
juliagallucci
left a comment
There was a problem hiding this comment.
Great! Your code is well executed and concise. Be sure to comment your code for improved clarity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports) I updated the Assignment 1 file with my code and answers.
What did you learn from the changes you have made?
Creating a function to evaluate anagram checker using sorted and Lower functions.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I was open to learning so I didnt have any approach in mind.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
None. The lecture notes and video was enough to get through the assignment.
How were these changes tested?
I ran the code on python to evaluate the outcomes.
A reference to a related issue in your repository (if applicable)
None
Checklist