Open
Conversation
juliagallucci
suggested changes
Oct 21, 2025
juliagallucci
left a comment
There was a problem hiding this comment.
You're close! However, the logic for handling is_case_sensitive is reversed. Right now, it always converts both words to lowercase before comparing, even when is_case_sensitive=True! Please revise
juliagallucci
approved these changes
Oct 27, 2025
juliagallucci
left a comment
There was a problem hiding this comment.
Great! One note for improvement, you don’t need to explicitly return True or False since the comparison itself already evaluates to a Boolean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I added code to assignment_1.ipynb
What did you learn from the changes you have made?
I learned how to define a function to build an anagram checker and expand its functionality with a boolean option for case sensitivity.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
There was no other approach.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
One challenge I faced was writing the correct nested conditionals to obtain the anticipated output. I overcame this by breaking it down into separate if else conditional statements to understand the code I needed before trying to nest them.
How were these changes tested?
I saved the assignment_1.ipynb file in a separate folder then tested and modified the code as necessary. In this file, I also tested other strings/anagrams of different lengths and with different cases and characters (for example “Note_3”, “tone”).
A reference to a related issue in your repository (if applicable)
Checklist