Conversation
There was a problem hiding this comment.
Can't the recipe use the zipball from github? Aka https://github.com/Tribler/tribler/archive/devel.zip
Otherwise, please enhance the recipe to prevent downloading /cloning the repo everytime :)
There was a problem hiding this comment.
The problem with the archive is that it doesn't download the git submodules. I'll have a look at this and perhaps package the submodules separately, probably the preferred option, or see if I can do something about the cloning.
There was a problem hiding this comment.
Tribler uses git submodules for Dispersy and pymdht. It then makes imports such as Tribler.dispersy.etc. and something similar for pydmht. So it expects these two modules to be present inside libtribler (and not externally). Using the direct archive from GitHub means that these submodules will be missing, like Darsestheus stated.
The approach in my latest commit is that libtribler is recursively cloned (as to include submodules) to $PACKAGES_PATH/libtribler. This is only done if it hasn't been cloned before. If it has been cloned before than a git pull command is executed instead to fetch the latest changes. In case any changes were fetched (it checks this by comparing the latest commit hash before and after pulling), or in the case that the build directory is empty, the libtribler directory (in $PACKAGES_PATH/libtribler) is copied to the build directory (in $BUILD_libtribler).
…. Alsp stores a cache of libtribler in packages as well.
|
Picking up this work for my master thesis project. I need the following missing recipes for Tribler; so they need to be recreated for the new p4a-toolchain:
|
|
All required recipes mentioned above are now done. |
|
@brussee Thanks for all these, and I'm sorry for the delay with merging them, I've had less time than I hoped for p4a recently but expect to be able to look at everything properly soon. |
Add a recipe for libtribler. Tribler can be found at https://github.com/Tribler/tribler.