✔️ Deploy Preview for knative ready!

🔨 Explore the source changes: 36ffccd

🔍 Inspect the deploy log: https://app.netlify.com/sites/knative/deploys/613631352d37a9000805a773

😎 Browse the preview: https://deploy-preview-4162--knative.netlify.app

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Welcome @sankalp-r! It looks like this is your first PR to knative/docs 🎉

Hi @sankalp-r. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

@googlebot I signed it!

@sankalp-r @RichardJJG @snneji there's no correct term listed for this, should we provide something here? Maybe either "can" or "must" if an action is required?

/ok-to-test

@sankalp-r @RichardJJG @snneji there's no correct term listed for this, should we provide something here? Maybe either "can" or "must" if an action is required?

Both would work - "must" if an action is required or "can" if an action is optional.

Also, since the list is in alphabetical order, the item would need to move from being on the last row.

@sankalp-r @RichardJJG @snneji there's no correct term listed for this, should we provide something here? Maybe either "can" or "must" if an action is required?

I would leave the "Correct" cell empty (n/a) and explain in the "Notes" cell that, as far as possible, the sentence should be re-written to not use "should" or any synonym of "should".

@sankalp-r @RichardJJG @snneji there's no correct term listed for this, should we provide something here? Maybe either "can" or "must" if an action is required?

I agree with @RichardJJG .
As "Correct" cell is empty, keeping this at last row seems fine to me.

There seem to be some tests failing on this PR. It looks like it might be a Git setup issue?

 Committer identity unknown

*** Please tell me who you are.

Run

  git config --global user.email "[email protected]"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: empty ident name (for <runner@fv-az252-375.0oqgmj5p5touvf5anqlk4y4b0b.jx.internal.cloudapp.net>) not allowed
Error: Process completed with exit code 128.

https://github.com/knative/docs/pull/4162/checks?check_run_id=3476356521

There's also a more minor whitespace error: https://github.com/knative/docs/pull/4162/checks?check_run_id=3476356522

There seem to be some tests failing on this PR. It looks like it might be a Git setup issue?

 Committer identity unknown

*** Please tell me who you are.

Run

  git config --global user.email "[email protected]"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: empty ident name (for <runner@fv-az252-375.0oqgmj5p5touvf5anqlk4y4b0b.jx.internal.cloudapp.net>) not allowed
Error: Process completed with exit code 128.

https://github.com/knative/docs/pull/4162/checks?check_run_id=3476356521

There's also a more minor whitespace error: https://github.com/knative/docs/pull/4162/checks?check_run_id=3476356522

Fixed the above mentioned issues.

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, sankalp-r

The full list of commands accepted by this bot can be found here.

The pull request process is described here