Reset sharpening buffer for every Quad#435
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR moves the sharpening buffer reset from a global decoder reset to a per-quad operation, ensuring fresh buffer state for each quad during AprilTag decoding. The change also includes parameter adjustments to improve detection accuracy.
- Moved sharpening buffer reset from decoder-level to per-quad processing
- Increased decode_sharpening from 0.15 to 0.25 for better edge detection
- Reduced min_white_black_difference from 20 to 5 for improved sensitivity
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/kornia-apriltag/src/lib.rs | Removed global reset method and updated detection parameters |
| crates/kornia-apriltag/src/decoder.rs | Added per-quad sharpening buffer reset in decode_tags function |
edgarriba
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.