Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates CI workflow configurations for improved reliability and makes minor type improvements to tensor methods. The changes focus on standardizing toolchain management and updating dependencies across multiple workflow files.
- Updated sccache GitHub Action from v0.0.8 to v0.0.9 across all CI workflows
- Standardized Rust toolchain installation commands in lint workflows
- Added explicit lifetime annotations to tensor view methods for better type safety
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| devel-x86_64.Dockerfile | Updated base image to use rolling rust:1 tag instead of specific version |
| crates/kornia-tensor/src/tensor.rs | Added explicit lifetime annotations to tensor view method return types |
| .github/workflows/rust_test.yml | Updated sccache action version to v0.0.9 |
| .github/workflows/rust_release.yml | Updated sccache action version to v0.0.9 |
| .github/workflows/rust_lint.yml | Standardized toolchain installation and updated sccache action |
| .github/workflows/python_test.yml | Updated sccache action and cleaned up formatting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
cjpurackal
approved these changes
Sep 17, 2025
edgarriba
reviewed
Sep 18, 2025
jeffin07
pushed a commit
to jeffin07/kornia-rs
that referenced
this pull request
Sep 19, 2025
* attempt 1 * Update sccache-action to v0.0.9 in CI workflows * Update Rust base image to version 1.89 * Update base image to rust:1 in Dockerfile to ensure latest stable version is used * Fix clippy
andrew-shc
pushed a commit
to andrew-shc/kornia-rs
that referenced
this pull request
Sep 22, 2025
* attempt 1 * Update sccache-action to v0.0.9 in CI workflows * Update Rust base image to version 1.89 * Update base image to rust:1 in Dockerfile to ensure latest stable version is used * Fix clippy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates several CI workflow configurations and makes minor improvements to type signatures in the tensor implementation. The main changes are focused on updating the
sccacheGitHub Action version across all workflows, standardizing Rust toolchain installation commands, and improving lifetime annotations in tensor view methods.CI workflow updates:
mozilla-actions/sccache-actionversion fromv0.0.8tov0.0.9in all relevant CI workflow files (python_test.yml,rust_lint.yml,rust_release.yml,rust_test.yml) for improved caching reliability. [1] [2] [3] [4] [5] [6] [7]rust_lint.ymlby replacingdtolnay/rust-toolchain@stableandrustup toolchain install stablewith a singlerustup updatecommand. [1] [2]python_test.ymlby removing unnecessary blank lines for better readability. [1] [2] [3]Tensor implementation improvements:
reshape,permute_axes, andviewmethods inTensorto include explicit lifetime annotations, improving type safety and clarity. [1] [2] [3]Dockerfile update:
devel-x86_64.Dockerfilefromrust:1.85to the rollingrust:1tag to always use the latest Rust 1.x version.