migrate the javax.annotation.* to jakarta.annotation.*#2627
migrate the javax.annotation.* to jakarta.annotation.*#2627tmrpavan wants to merge 0 commit intokubernetes-client:masterfrom
Conversation
|
@brendanburns, @yue9944882 Can you review my PR |
|
@brendandburns, @yue9944882 Can you review this PR -> #2627 |
|
@brendanburns, @yue9944882 Can you review my PR |
|
don' spam the contributor just have some patience |
|
Unfortunately, we need to make this change in the code generator, not here, since this code is generated and these changes will get overwritten the next time we generate. The generator repo is here: I think you need to add |
|
Created PR as per your comments. Can you please review it. PR -> kubernetes-client/gen#241 |
|
Is this PR generated by the code generator? Thanks |
|
@brendandburns No, I am working on this |
|
@brendandburns I am getting below error while building client. Can you help me on this --- Running generator inside container... |
|
I have generated the code using code generator. Still it is javax.annotation.* only. @brendandburns Can you help me on this |
|
I think that is all that the generator currently supports. Let's merge this PR for now, we can look into SSL in a follow-up. Also, the merge bot is unhappy b/c you have an Thanks! |
5936add to
35c4d00
Compare
35c4d00 to
db604d0
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tmrpavan The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@brendandburns I closed this PR and created new request #2642 |
migrate the javax.annotation.* to jakarta.annotation.* -> #2606