Skip to content

migrate the javax.annotation.* to jakarta.annotation.*#2627

Closed
tmrpavan wants to merge 0 commit intokubernetes-client:masterfrom
tmrpavan:tmrpavan-javax-to-jakarta
Closed

migrate the javax.annotation.* to jakarta.annotation.*#2627
tmrpavan wants to merge 0 commit intokubernetes-client:masterfrom
tmrpavan:tmrpavan-javax-to-jakarta

Conversation

@tmrpavan
Copy link
Copy Markdown

migrate the javax.annotation.* to jakarta.annotation.* -> #2606

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 10, 2023
@k8s-ci-robot k8s-ci-robot requested a review from yue9944882 April 10, 2023 09:48
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 10, 2023
@tmrpavan
Copy link
Copy Markdown
Author

@brendanburns, @yue9944882 Can you review my PR

@tmrpavan
Copy link
Copy Markdown
Author

@brendandburns, @yue9944882 Can you review this PR -> #2627

@tmrpavan
Copy link
Copy Markdown
Author

@brendanburns, @yue9944882 Can you review my PR

@Mohdcode
Copy link
Copy Markdown

don' spam the contributor just have some patience

@brendandburns
Copy link
Copy Markdown
Contributor

Unfortunately, we need to make this change in the code generator, not here, since this code is generated and these changes will get overwritten the next time we generate.

The generator repo is here:
https://github.com/kubernetes-client/gen

I think you need to add <useJakartaEe>true</useJakartaEe> to the configOptions in the java.xml file to activate this.

@tmrpavan
Copy link
Copy Markdown
Author

@brendandburns

Created PR as per your comments. Can you please review it. PR -> kubernetes-client/gen#241

@brendandburns
Copy link
Copy Markdown
Contributor

Is this PR generated by the code generator? Thanks

@tmrpavan
Copy link
Copy Markdown
Author

@brendandburns No, I am working on this

@tmrpavan
Copy link
Copy Markdown
Author

@brendandburns I am getting below error while building client. Can you help me on this

--- Running generator inside container...
/usr/local/bin/mvn-entrypoint.sh: 50: exec: /generate_client.sh: not found

@tmrpavan
Copy link
Copy Markdown
Author

I have generated the code using code generator. Still it is javax.annotation.* only.

@brendandburns Can you help me on this

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Apr 22, 2023
@brendandburns
Copy link
Copy Markdown
Contributor

I think that is all that the generator currently supports. Let's merge this PR for now, we can look into SSL in a follow-up.

Also, the merge bot is unhappy b/c you have an @ symbol in your commit message. Can you remove that to make it easier to merge this PR? You can use git commit --amend to re-edit the commit message.

Thanks!

@tmrpavan tmrpavan force-pushed the tmrpavan-javax-to-jakarta branch 2 times, most recently from 5936add to 35c4d00 Compare April 23, 2023 15:13
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Apr 23, 2023
@tmrpavan tmrpavan closed this Apr 23, 2023
@tmrpavan tmrpavan force-pushed the tmrpavan-javax-to-jakarta branch from 35c4d00 to db604d0 Compare April 23, 2023 16:20
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tmrpavan

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 23, 2023
@tmrpavan tmrpavan deleted the tmrpavan-javax-to-jakarta branch April 23, 2023 16:36
@tmrpavan
Copy link
Copy Markdown
Author

@brendandburns I closed this PR and created new request #2642

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants