Fix watch to emit an error twice on error. Add tests.#396
Merged
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom Jan 24, 2020
Merged
Fix watch to emit an error twice on error. Add tests.#396k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
drubin
reviewed
Jan 23, 2020
src/watch_test.ts
Outdated
| expect(doneCalled).to.equal(true); | ||
| expect(doneErr).to.deep.equal(errIn); | ||
| expect(doneErr.length).to.equal(2); | ||
| if (doneErr.length == 2) { |
Contributor
There was a problem hiding this comment.
This if check is redundant as the first check already guards against it.
Contributor
|
@brendandburns the linting is off but it looks good. |
05cd766 to
81a540a
Compare
81a540a to
e4ac479
Compare
Contributor
Author
|
lint fixed, comment addressed. Please re-check. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #392