Skip to content

Add prepack script to package scripts#562

Merged
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
DocX:patch-1
Dec 23, 2020
Merged

Add prepack script to package scripts#562
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
DocX:patch-1

Conversation

@DocX
Copy link
Copy Markdown
Contributor

@DocX DocX commented Dec 3, 2020

prepack is needed to be compatible with yarn when installing from github or local source. See yarn documentation: https://yarnpkg.com/advanced/lifecycle-scripts

prepack is also defined in npm: https://docs.npmjs.com/cli/v6/using-npm/scripts#life-cycle-scripts

@DocX
Add prepack script to package scripts
ea3a4d1 
prepack is needed to be compatible with `yarn` when installing from github or local source. See yarn documentation: https://yarnpkg.com/advanced/lifecycle-scripts

prepack is also defined in npm: https://docs.npmjs.com/cli/v6/using-npm/scripts#life-cycle-scripts
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 3, 2020

Welcome @DocX!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 3, 2020

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 3, 2020
@brendandburns
Copy link
Copy Markdown
Contributor

brendandburns commented Dec 3, 2020

Looks fine to me, but we need you to sign the CLA.

Thanks!

@DocX
Copy link
Copy Markdown
Contributor Author

DocX commented Dec 17, 2020

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 17, 2020
@brendandburns
Copy link
Copy Markdown
Contributor

brendandburns commented Dec 23, 2020

/lgtm
/approve

(apologies for missing the update on this one)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 23, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 23, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, DocX

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5f0c70f into kubernetes-client:master Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@drubin drubin Awaiting requested review from drubin

Assignees

@brendandburns brendandburns

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DocX @k8s-ci-robot @brendandburns