Skip to content

Regenerate and Refactor for v1.11#57

Closed
burn2delete wants to merge 2 commits intokubernetes-client:masterfrom
burn2delete:v1.11
Closed

Regenerate and Refactor for v1.11#57
burn2delete wants to merge 2 commits intokubernetes-client:masterfrom
burn2delete:v1.11

Conversation

@burn2delete
Copy link
Copy Markdown
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 1, 2018
@brendandburns
Copy link
Copy Markdown
Contributor

Needs rebase because I merged some older PRs...

Note that everything moved into the src/ directory here:

#4

It's not entirely clear to me what the canonical layout for a JS/TS library should be..

Do you have any pointers to a widely use standard layout? Thanks!

@svenefftinge in case there are comments about why we moved to 'src' in the first place...

@burn2delete
Copy link
Copy Markdown
Contributor Author

@brendanburns the kubernetes-client/gen repo has a suggestion for how to structure client projects:

Recommended structure is to generate client in a folder called "kubernetes" at the root of the client repo and put all settings in a file named "settings" at the root of the repo. If you followed these recommendations, you can simply run autoupdate script anywhere inside the client repo:

The other clients also do this:
https://github.com/kubernetes-client/haskell
https://github.com/kubernetes-client/java
https://github.com/kubernetes-client/python

@brendandburns
Copy link
Copy Markdown
Contributor

I guess my question was more around how javascript libraries in general are laid out. I don't care about aligning with other clients as much as I care about aligning with what Node/JS developers expect...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants