Skip to content

🌱 Add e2e tests for IPAM provider to Cluster API Operator Helm chart#734

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
rgeraskin:add-ipam-provider-helm-chart-tests
Mar 12, 2025
Merged

🌱 Add e2e tests for IPAM provider to Cluster API Operator Helm chart#734
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
rgeraskin:add-ipam-provider-helm-chart-tests

Conversation

@rgeraskin
Copy link
Copy Markdown
Contributor

@rgeraskin rgeraskin commented Feb 26, 2025

What this PR does / why we need it:

This PR brings e2e tests for the IPAM provider into the Cluster API Operator Helm chart, on top of what was done in PR #688.

  • Update core-conditions.yaml to include IPAM provider in deployment conditions
  • Add IPAM provider test cases in helm_test.go
  • Create new / update test resource files for IPAM provider scenarios

@rgeraskin
test: add Helm chart e2e tests for IPAM provider
2f73b05 
- Update core-conditions.yaml to include IPAM provider in deployment conditions
- Add IPAM provider test cases in helm_test.go
- Create new / update test resource files for IPAM provider scenarios
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 26, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 26, 2025

Hi @rgeraskin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 26, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 26, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!

Name Link
🔨 Latest commit 2f73b05
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-operator/deploys/67be5f60785f120008561700
😎 Deploy Preview https://deploy-preview-734--kubernetes-sigs-cluster-api-operator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@furkatgofurov7
Copy link
Copy Markdown
Member

furkatgofurov7 commented Feb 26, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 26, 2025
furkatgofurov7
furkatgofurov7 approved these changes Mar 3, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furkatgofurov7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2025
@rgeraskin
Copy link
Copy Markdown
Contributor Author

rgeraskin commented Mar 10, 2025

@furkatgofurov7 this PR still missing lgtm label afaik. Should I do anything to kick the process off?

@furkatgofurov7
Copy link
Copy Markdown
Member

furkatgofurov7 commented Mar 10, 2025

@rgeraskin hey, no. It is just missing lgtm label from other maintainers, but already has approve.

cc @alexander-demicev @Danil-Grigorev @Fedosin PTAL

mjura
mjura approved these changes Mar 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mjura mjura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Danil-Grigorev
Danil-Grigorev approved these changes Mar 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 12, 2025

LGTM label has been added.

DetailsGit tree hash: 69b20ba5c387136bcf50e2228330517a99f0e39a

@k8s-ci-robot k8s-ci-robot merged commit 879f013 into kubernetes-sigs:main Mar 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Danil-Grigorev Danil-Grigorev Danil-Grigorev approved these changes

@furkatgofurov7 furkatgofurov7 furkatgofurov7 approved these changes

@alexander-demicev alexander-demicev Awaiting requested review from alexander-demicev

+1 more reviewer

@mjura mjura mjura approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Danil-Grigorev Danil-Grigorev

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rgeraskin @k8s-ci-robot @furkatgofurov7 @mjura @Danil-Grigorev