Skip to content

Revert "Revert "Update assignment script""#3

Open
lantleUofT wants to merge 2 commits intomainfrom
revert-2-revert-1-assignment
Open

Revert "Revert "Update assignment script""#3
lantleUofT wants to merge 2 commits intomainfrom
revert-2-revert-1-assignment

Conversation

@lantleUofT
Copy link
Copy Markdown
Owner

Reverts #2

Copy link
Copy Markdown

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the requested change. Everything else looks good.

Comment thread 02_activities/assignments/assignment.sh Outdated

# 1. Create a directory named data

cd "/Users/levi/Documents/Documents/Graduate School Stuff/DSI certification class/DSI coding/Assignement 1/shell/assignments/newproject"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line of code is not required since it is used for testing, its hardcoded path and not portable. Please delete this cd command.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change should be made!

Copy link
Copy Markdown

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Well done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants