(issue 788) convert unicode string to bytes and reversely when working wiht HDF files#789
Merged
alixdamman merged 3 commits intolarray-project:masterfrom Aug 5, 2019
Conversation
…y when dumping/loading Axis and Group objects to/from HDF files (to avoid huge size hdf files)
Collaborator
Author
|
needs a changelog? |
gdementen
approved these changes
Aug 5, 2019
Contributor
gdementen
left a comment
There was a problem hiding this comment.
my only nitpick is that I find the attribute "kind" not very telling. maybe dtype_kind of data_kind or ?
Contributor
|
For the changelog, if the only consequence is to make sessions with standalone "unicode axes" (or groups) smaller, then probably not (because those or not used yet AFAIK). If it also has an impact on arrays with such axes, then yes. |
This was referenced Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.