Conversation
Collaborator
|
Please make a PR with only the URL changes (i.e only the "eurostat_get with new API) commit without the OLD API comment. The get_index/cache/frequency extraction stuff should go to the new datasources package (they are not needed for the fix anyway) |
gdementen
requested changes
Oct 18, 2023
|
|
||
|
|
||
| EUROSTAT_BASEURL = "https://ec.europa.eu/eurostat/estat-navtree-portlet-prod/BulkDownloadListing?sort=1&file=" | ||
| # OLD API: EUROSTAT_BASEURL = "https://ec.europa.eu/eurostat/estat-navtree-portlet-prod/BulkDownloadListing?sort=1&file=" |
Collaborator
There was a problem hiding this comment.
This kind of "historical" comment is not needed/discouraged when using Git.
| ## OLD EUROSTAT API was deprecated anno 23 october 2023. | ||
| ## Minor modification were made in below functionality (which supports caching). | ||
| ## | ||
| ## CHANGES: - change of base url for compatibility with new API |
Collaborator
There was a problem hiding this comment.
This kind of "historical"/"changelog" comment is not needed/discouraged when using Git.
Collaborator
|
superseded by #32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.