Skip to content

(WIP) Refactor L1 tests out of LCacheTest.php and into separate test classes#72

Closed
stevector wants to merge 43 commits intomasterfrom
test-refactor--trait-for-shared-tests
Closed

(WIP) Refactor L1 tests out of LCacheTest.php and into separate test classes#72
stevector wants to merge 43 commits intomasterfrom
test-refactor--trait-for-shared-tests

Conversation

@stevector
Copy link
Copy Markdown
Contributor

@stevector stevector commented Dec 5, 2016 •
edited
Loading

Overview

This pull request:

  • Breaks up the test suite into different classes and traits.

Summary

This PR is a work-in-progress and should not be merged. It is part two of #70

Todo

  • Wait for Improve consistency of tests used on L1s. #71 to be merged.
  • Remove changes to L2 and integration testing so that only L1 classes are tested in this PR.
  • Validate that this test suite in this branch has an identical number of tests and assertions as the master branch (as a way of indicating that the substance of the test suite has not changed)
  • Validate that traits within the test suite are the preferred means of reuse.
  • Rebase or squash commits when merging.

@stevector
NullL1 test
f24f233
@stevector
adding sqlitel1test
5a484aa
@stevector
refactoring sqlitel1test
7275d8c
@stevector
adding APCuL1Test
4571c5d
@stevector
Fixing method placement
b131d05
@stevector
Adding staticL1Test
7e684b3
@stevector
staticL1Test
564ff18
@stevector
phpcs fixes
c41e6d5
@stevector
whitespace
b20e791
@stevector
whitespace
4d59c8f
@stevector
splitting L2TestHelpers
e94a4f5
@stevector
adding StaticL2Test.php
e629a81
@stevector
moving methods
efdda9a
@stevector
moving methods to StaticL2Test
e38941a
@stevector
whitespace
0c90342
@stevector
whitespace
b1f9144
@stevector
Using DatabaeL2Test.php
cc16f0b
@stevector
Using DatabseL2Test
ac89261
@stevector
trying to fix namespace problem with traits
c1cd0bf
@stevector
removing manual require statements
de2cf85
@stevector
trait for required l1 tests
8864ffc
@stevector
using requiredtests
b0f9a65
@stevector
more break up into required tests
acf0a95
@stevector
Getting APCU to pass performSetGetDeleteTest()
5c0cf87
@stevector
whitespace
ec0d649
@stevector
Whitespace
9f7166a
@stevector
namespace update
a046e3a
@stevector
namespace update
a10eb06
@stevector
Moving sync test
2d7673b
@stevector
expiration cleanup
21563d1
This was referenced Dec 5, 2016
Merged
Closed
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 5, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 58bfad8 on test-refactor--trait-for-shared-tests into 7adddaa on master.

@davidstrauss davidstrauss added this to the v1.0.0 milestone Dec 6, 2016
@stevector
Copy link
Copy Markdown
Contributor Author

stevector commented Dec 12, 2016

I'll update this PR after #73 gets merged.

@ndobromirov ndobromirov mentioned this pull request Dec 12, 2016
Open
@stevector stevector changed the title Break up L1CacheTest.php into separate test classes. Refactor L1 tests out of LCacheTest.php and into separate test classes Dec 16, 2016
@stevector stevector changed the title Refactor L1 tests out of LCacheTest.php and into separate test classes (WIP) Refactor L1 tests out of LCacheTest.php and into separate test classes Dec 16, 2016
@davidstrauss
Copy link
Copy Markdown
Member

davidstrauss commented Dec 28, 2016

@stevector How are we looking here? Should we close this and start from scratch to handle your remaining goals for this PR?

@stevector
Copy link
Copy Markdown
Contributor Author

stevector commented Dec 28, 2016

@davidstrauss I think #76 covered everything I intended here.

@stevector stevector closed this Dec 28, 2016
@stevector stevector deleted the test-refactor--trait-for-shared-tests branch December 28, 2016 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

v1.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@stevector @coveralls @davidstrauss