-
Notifications
You must be signed in to change notification settings - Fork 7
L2 & Integrated - tests refactoring #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ndobromirov
wants to merge
55
commits into
lcache:main
Choose a base branch
from
ndobromirov:l2-tests-refactoring
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
419cdd8
Refactoring in DatabaseL2 for readability. Added TODOs and utils.
ndobromirov 047851e
Kick-off on the L2 tests refactoring.
ndobromirov 6b7a3f3
CS fixes.
ndobromirov 43b389a
Fix code coverage. Added some docks.
ndobromirov e378fc7
Code coverage iteration.
ndobromirov d30b6da
Improved delete queue consistency to avoide reliance of other process…
ndobromirov b4f91c0
Implemented clean-up after write for the StaticL2 driver, so it will …
ndobromirov 239cd11
Imrpved code reusage in DatabaseL2. Added docks to LX and L2 base cla…
ndobromirov e712eb6
Reflow of the integrated layer. Added some inline docks.
ndobromirov 4f1d07f
DatabaseL2: single query to insert cache tags. Refactoring to increas…
ndobromirov 0068125
Added new Entity::isExpired. Used it to strenghten the StaticL1::isNe…
ndobromirov f0b649f
Refactored SQLiteL1 sql statments for readability.
ndobromirov 12cc277
Added a new test to validate L1::isNegativeCache consistency for all …
ndobromirov cb72108
Added a test for L2::applyEvents. Fixed incompatability in StaticL2 a…
ndobromirov cbba6dc
Implemented a dedicated L2::deleteTag test. Fixed StaticL2 interface …
ndobromirov 3ddc2af
Removed code coverage ignore tags from 2 methods in StaticL2.
ndobromirov d530702
Moved shared logick from StaticL2 and DatabaseL2 to L2 abstract - the…
ndobromirov 0ffea2d
Micro-optimisations. Re-ordered code in StaticL2 to match the Databas…
ndobromirov 64a0285
Added a test for the L2 garbage collection related interfaces. Fixed …
ndobromirov 82db81b
Improved consistency between StaticL2 and DatabaseL2. Performance imp…
ndobromirov ae09451
Disabled DatabaseL2::collectGarbage limit input for all SQLite storage.
ndobromirov 6557519
Refactor the L2::collectGarbage test to enforce the correct API as mu…
ndobromirov 05ef967
Audit the TODOs in code. Removed the ones that are not relevant anymore.
ndobromirov 3b1372d
Improved the L2::applyEvents test.
ndobromirov 79dd94b
API change. Separated the StateL1 creation from the L1 creation into …
ndobromirov 32cd578
Added test coverage for all L1 state managers. Improved documentation…
ndobromirov 8ffcade
Addres::isMatch micro optimisation.
ndobromirov 0c2d48f
Refactor the tests for the state managers to have no cross-metod depe…
ndobromirov e53f381
Added groupings on state, L1 and L2 so test can be run partially.
ndobromirov 4fe462f
Added combinatory tests to L1, so every L1 cache driver is tested aga…
ndobromirov 6c84d85
Prepared the bases for the integrated layer tests.
ndobromirov e3650cf
Ported the tests: testNewPoolSynchronization.
ndobromirov 5d3ce78
Ported the tombstone test for the integration layer.
ndobromirov ab5eb6b
Fixed integrated API regression.
ndobromirov 06694ba
Fixed integrated API regression 2.
ndobromirov 88d5e7a
L2: Clear whole pool api ported to new L2 tests structure.
ndobromirov 8ea7445
L2: Ported L2 expiration test.
ndobromirov fd106ba
L2: Ported reread test.
ndobromirov 8d38c2a
Ported pool sinchronization test. Improved the test to combine all po…
ndobromirov 8d46d75
Integrated: Ported pool clear sinchronization test.
ndobromirov 7bfe297
Integration: API addition getAddressesForTag(). Ported the testTagged…
ndobromirov bda8deb
Ported the test for broken DatabaseL2 used in the integration layer.
ndobromirov c4397c8
Integration: Ported the test - Sync with no writes.
ndobromirov f607675
Integrated: Ported the existence test.
ndobromirov 9d56dfe
Integrated: Ported the poll value access test.
ndobromirov a34e97d
Integrated: Ported expiration test.
ndobromirov 67512a1
Integrated: Ported excessive overhead skipping test.
ndobromirov ea61e23
Integrated: Ported hit-set-counter (key overhead) test.
ndobromirov 501c951
Integrated: Ported the failed unserialization test.
ndobromirov 8a5b9ca
Integrated: Ported the garbage colletion tests.
ndobromirov a5088a0
Integrated: Ported tests for wrong serialization cases. L1: Ported th…
ndobromirov 8f937d7
Removed the LcacheTest class as obsolete (no tests are left in it).
ndobromirov a32dba5
Fixed code coverage (iteration 1).
ndobromirov 52b2041
Fixed code coverage (iteration 2). Reverted the exception handling fo…
ndobromirov b9e4118
Fixed the Integrated API hacks. Moved them to the wrapper IntegratedM…
ndobromirov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added, so when a new annotation is added to a test like:
@group failing
The composer test-failing command will trigger only that test.
Useful when debugging a single test.