Skip to content

not lookup path in db proxy cmd#509

Merged
cshuaimin merged 3 commits intomasterfrom
fix-db-conn-info
Jun 27, 2022
Merged

not lookup path in db proxy cmd#509
cshuaimin merged 3 commits intomasterfrom
fix-db-conn-info

Conversation

@cshuaimin
Copy link
Copy Markdown
Contributor

https://www.leanticket.cn/tickets/39970

输出连接信息时,跳过检查命令是否存在,直接用最后一个(最常见的那个)。

另外 sys 包太老了在 Go 1.18 编译报错,更新一下。

@cshuaimin cshuaimin requested a review from qiuyi116 June 27, 2022 02:53
return nil, errors.New(msg)
}
} else {
cli = clis[len(clis)-1]
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

截屏2022-06-27 10 56 09

这里的 diff 有点问题,实际上就是加了个 if else

@qiuyi116
Copy link
Copy Markdown
Contributor

PS,是不是可以考虑切换到 go mod,不再使用 vendor 了?

@cshuaimin cshuaimin merged commit 451fa56 into master Jun 27, 2022
@cshuaimin cshuaimin deleted the fix-db-conn-info branch June 27, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants