Fix GITHUB_REF is wrong for jobs triggered with closed PRs#523
Merged
Fix GITHUB_REF is wrong for jobs triggered with closed PRs#523
Conversation
jysperm
approved these changes
Mar 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub 这太坑了……先是 GITHUB_SHA 指向的是 PR 要合并到的 commit，而不是 PR 最新的 commit（在 push 等其他事件中却指向的是要 push 的 commit）；再是 GITHUB_REF 在创建 PR 的时候是对的，但合并 PR 的时候就不对了……文档中只字未提，只有遇到了才能发现……