Closed
Conversation
Melevir
reviewed
Feb 16, 2023
|
|
||
|
|
||
| def compose_full_name(first_name: ___, last_name: ___, middle_name: ___) -> ___: | ||
| def compose_full_name(first_name: str, last_name: str, middle_name: str) -> str: |
Contributor
There was a problem hiding this comment.
Глянь внимательнее на вызовы функции, у мидл нейма не такая аннотация.
|
|
||
|
|
||
| def send_email(header: ___, text_content: ___, send_to: ___) -> ___: | ||
| def send_email(header: str, text_content: str, send_to: str) -> bool | None: |
Contributor
There was a problem hiding this comment.
Непонятно, почему в возвращаемый тип затесался бул, вроде ничего на это не намекает.
| @@ -1,10 +1,11 @@ | |||
| import decimal | |||
| import uuid | |||
| from _decimal import Decimal | |||
Contributor
There was a problem hiding this comment.
Этот импорт лишний. Выше есть импорт модуля decimal, поэтому просто используй decimal.Decimal для аннотации.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.