Skip to content

Added new file assignment-one-entity-diagram.png#1

Open
lebronbrian23 wants to merge 3 commits intomainfrom
assignment-one
Open

Added new file assignment-one-entity-diagram.png#1
lebronbrian23 wants to merge 3 commits intomainfrom
assignment-one

Conversation

@lebronbrian23
Copy link
Copy Markdown
Owner

@lebronbrian23 lebronbrian23 commented Aug 10, 2025

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Added new file called assignment-one-entity-diagram.png.
Modified assignment1.sql.

What did you learn from the changes you have made?

Writing SQL Queries.

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

Unit tested each query

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@DwardEE DwardEE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Brian!

Please revisit the relationship shown in your logical diagram. It shouldn't be a 1-1
relationship.

Nice work with the questions. Your SELECTs, WHERE (one option correct), JOIN with ordering, aggregates, and the temp table all look good. For the pepper flag, make it case-insensitive so you don’t miss “Pepper/PEPPER.” Feel free to make changes to this, but it's quite minor.

Edit: Oops, I meant to request changes not approve, but let me know when you update the logical diagram.

@lebronbrian23
Copy link
Copy Markdown
Owner Author

@DwardEE
I have uploaded new changes and added a new diagram

Copy link
Copy Markdown

@DwardEE DwardEE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants