Conversation
|
✔️ Deploy Preview for inspiring-nightingale-2fbde7 ready! 🔨 Explore the source changes: 0c47ab8 🔍 Inspect the deploy log: https://app.netlify.com/sites/inspiring-nightingale-2fbde7/deploys/61f82f775097c1000754733c 😎 Browse the preview: https://deploy-preview-23--inspiring-nightingale-2fbde7.netlify.app/ |
natandias
left a comment
There was a problem hiding this comment.
I think it would be better if the search box stayed in the same line as the nav items, maybe it could be positioned on the right side. And since that, in the mobile design, the search box appears too small, I think that it could be positioned inside the hamburguer menu, together with the other menu items.
Like this? Put the search on right and the others buttons on left in same line? |
|
You request my review, but it's no changes pushed yet. |
I requested on the other one, not here. Check it out: |
|
Also, what is the project issue related to this pr?? |
There isn't. Initially, this changes was just a suggestion by myself, but we talked about keep the original NavBar but with the same search box in this NavBar here. What do you think? |
Keeping the original NavBar and adding the Search bar from this one, what do you think? |
|
yeah, I think is better! |
|
Done! Check it out and let me know your thoughts. The code is almost fully changed, I kept original NavBar and add the Search bar. Also, I needed to fix some things to all work as expected. |
Just adding a new NavBar. I think it will fit better in the page, let me know what you think @Erickinhou.