Merged
Conversation
Contributor
ctoffanin
commented
Jul 18, 2019
- The pull request is complete according to the Definition of Done
- Acceptance criteria in the ticket have been met
- Automated tests are written according to the test plan
- The documentation is up-to-date
- Deployment automation includes newly introduced environment variables and credentials are added to the credentials.fact file of all servers
- The pull request has a descriptive title that describes what has changed, and provides enough context for the changelog
- When applicable, the pull request title starts with the issue number
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.