Skip to content

Fixed the chicked-and-egg problem with CFFI in setup.#407

Merged
jdavid merged 3 commits intolibgit2:masterfrom
opbeat:cffi-install-fix
Aug 21, 2014
Merged

Fixed the chicked-and-egg problem with CFFI in setup.#407
jdavid merged 3 commits intolibgit2:masterfrom
opbeat:cffi-install-fix

Conversation

@roncohen
Copy link
Copy Markdown
Contributor

This still needs some work in order to fix the problem
under windows. I have no windows machine here to test it.

Ron Cohen added 2 commits August 21, 2014 15:48
This still needs some work in order to fix the problem
under windows. I have no windows machine here to test it.
@jdavid
Copy link
Copy Markdown
Member

jdavid commented Aug 21, 2014

Thanks.

This makes pygit2 to require setuptools, I guess it does not work with just distutils, not a big deal anyway.

Regarding support for Windows, could you make BuildWithDLLs to inherit from CFFIBuild? At least it would theoretically work, while we wait for a Windows user to test.

@roncohen
Copy link
Copy Markdown
Contributor Author

There you go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants